Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call avifFixImageXMP() during jpg,png reading #1391

Merged
merged 3 commits into from
May 23, 2023
Merged

Call avifFixImageXMP() during jpg,png reading #1391

merged 3 commits into from
May 23, 2023

Conversation

y-guyon
Copy link
Collaborator

@y-guyon y-guyon commented May 12, 2023

Strip one null character from XMP chunks extracted from JPG and PNG files. Add regression test in avifmetadatatest.

See #1333.

@y-guyon
Call avifFixImageXMP() during jpg,png reading
a6cb979 
Strip one null character from XMP chunks extracted from JPG and PNG
files. Add regression test in avifmetadatatest.
@y-guyon y-guyon requested a review from wantehchang May 16, 2023 11:23
wantehchang
wantehchang approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix. The new test has a buffer overflow bug (off by one error).

CHANGELOG.md Outdated Show resolved Hide resolved
apps/shared/avifutil.h Outdated Show resolved Hide resolved
apps/shared/avifutil.c Outdated Show resolved Hide resolved
tests/data/README.md Outdated Show resolved Hide resolved
tests/gtest/avifmetadatatest.cc Outdated Show resolved Hide resolved
tests/gtest/avifmetadatatest.cc Outdated Show resolved Hide resolved
tests/gtest/avifmetadatatest.cc Show resolved Hide resolved
wantehchang
wantehchang approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@y-guyon y-guyon merged commit 6c5dec5 into AOMediaCodec:main May 23, 2023
@y-guyon y-guyon deleted the fix_xmp_with_trailing_null branch June 6, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wantehchang wantehchang wantehchang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y-guyon @wantehchang